Re: [Boost-bugs] [Boost C++ Libraries] #8027: thread library fails to compile with Visual Studio 2003

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #8027: thread library fails to compile with Visual Studio 2003
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2013-03-06 12:15:44

#8027: thread library fails to compile with Visual Studio 2003
-------------------------------------------+--------------------------------
  Reporter:  James Perry <jperry@…>        |       Owner:  viboes 
      Type:  Bugs                          |      Status:  closed 
 Milestone:                                |   Component:  thread 
   Version:  Boost 1.53.0                  |    Severity:  Problem
Resolution:  wontfix                       |    Keywords:         
-------------------------------------------+--------------------------------

Comment (by Manfred <kuhnkies@…>):

 Replying to [comment:3 viboes]:
 > Gald to see that this work for you. I will no make any change on the
 repository.

 Hello,

 I'm not sure whether I understood the meaning of this posting, regarding
 changes for the next release of boost. I really would appreciate the code
 being fixed for MSVC .NET 2003 in the next release of boost. Thanks to
 this ticket here we were able to reproduce the fix and to build boost
 thread on MSVC2003 at all. I.e. we have a conditional compilation flag
 around the lines L1390-L1396 above.

 before L1390: (file boost/thread/future.hpp, release 1_53_0)
  {{{#if (!defined _MSC_VER || _MSC_VER >= 1400) // _MSC_VER == 1400 on
 MSVC 2005}}}

 after L1396:
  {{{#endif // #if (!defined _MSC_VER || _MSC_VER >= 1400)}}}

 This should activate the code for compilers that don't define _MSC_VER
 (i.e. non-Microsoft compilers) and also for Microsoft compilers from MSVC
 2005 and newer; MSVC 2003 then disregards the lines it does not understand
 syntactically. With this modification, thread.lib was built successfully
 on MSVC 2003, 2008, 2010, 2012, MinGW GCC 4.7.2 on x86 and x64. I didn't
 test MSVC 2005 (don't have it any longer) and I was too lazy to test with
 a MinGW GCC 4.8.0 preview. I don't know if there are any side effects if
 that functions are not declared as friends (MSVC 2003 only), but until now
 there didn't occur any problems in our application.

 Best regards
   Manfred

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/8027#comment:4>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.