Re: [Boost-bugs] [Boost C++ Libraries] #8408: Boost is not compatible with Clang's -Wimplicit-fallthrough diagnostic

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #8408: Boost is not compatible with Clang's -Wimplicit-fallthrough diagnostic
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2013-04-09 19:02:20

#8408: Boost is not compatible with Clang's -Wimplicit-fallthrough diagnostic
------------------------------------------------------+---------------------
  Reporter:  Alexander Kornienko <alexfh@…>           |       Owner:  johnmaddock
      Type:  Patches                                  |      Status:  new        
 Milestone:  To Be Determined                         |   Component:  config     
   Version:  Boost Development Trunk                  |    Severity:  Problem    
Resolution:                                           |    Keywords:             
------------------------------------------------------+---------------------

Comment (by viboes):

 I think John is right. It would be better if the macro contains the ';' so
 that there is no risk in introducing a new warning.

 {{{
 #if __cplusplus >= 201103L && defined(__has_warning)
 #  if __has_feature(cxx_attributes) && __has_warning("-Wimplicit-
 fallthrough")
 #    define BOOST_FALLTHROUGH [[clang::fallthrough]];
 #  endif
 #endif
 }}}

 and

 {{{
 #ifndef BOOST_FALLTHROUGH
 #  define BOOST_FALLTHROUGH
 #endif
 }}}

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/8408#comment:9>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.