Re: [Boost-bugs] [Boost C++ Libraries] #8408: Boost is not compatible with Clang's -Wimplicit-fallthrough diagnostic

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #8408: Boost is not compatible with Clang's -Wimplicit-fallthrough diagnostic
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2013-04-10 16:41:02

#8408: Boost is not compatible with Clang's -Wimplicit-fallthrough diagnostic
------------------------------------------------------+---------------------
  Reporter:  Alexander Kornienko <alexfh@…>           |       Owner:  johnmaddock
      Type:  Patches                                  |      Status:  new        
 Milestone:  To Be Determined                         |   Component:  config     
   Version:  Boost Development Trunk                  |    Severity:  Problem    
Resolution:                                           |    Keywords:             
------------------------------------------------------+---------------------

Comment (by Alexander Kornienko <alexfh@…>):

 Replying to [comment:11 johnmaddock]:
 > I have to be honest: I'm not particularly taken by any of the solutions
 so far :-(
 >
 > By way of keeping it simple, what's wrong with just disabling (with
 pushes and pops) this warning in the few effected source files - rather
 like we do with MSVC warnings?  IMO it looks simpler and clearer to do it
 this way rather than introducing new macros etc...

 This macro could be a better alternative to fall-through/fall
 through/FALLTHROUGH/fallthrough/drop through/the lack of break is
 intentional/... and dozens of other variations of comments annotating this
 for humans. Frequently, there are no comments at all, so it's sometimes
 difficult to understand whether a fall-through is intentional or not.
 Having compiler-verifiable annotations would improve code readability and
 prevent a common kind of bug when one just forgets to put a 'break;'
 before next case label.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/8408#comment:14>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.