Re: [Boost-bugs] [Boost C++ Libraries] #8476: Make Boost.regex compatible with Clang's -Wimplicit-fallthrough diagnostic.

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #8476: Make Boost.regex compatible with Clang's -Wimplicit-fallthrough diagnostic.
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2013-04-23 15:56:46

#8476: Make Boost.regex compatible with Clang's -Wimplicit-fallthrough diagnostic.
------------------------------------------------------+---------------------
  Reporter:  Alexander Kornienko <alexfh@…>           |       Owner:  johnmaddock
      Type:  Patches                                  |      Status:  closed     
 Milestone:  To Be Determined                         |   Component:  regex      
   Version:  Boost Development Trunk                  |    Severity:  Problem    
Resolution:  fixed                                    |    Keywords:             
------------------------------------------------------+---------------------

Comment (by Alexander Kornienko <alexfh@…>):

 Thanks for applying the patch. Two things though:

 1. You've missed two times "break;" and one time "BOOST_FALLTHROUGH;".
 I've attached a diff from current HEAD to the version with the first
 patch.

 2. I've also noticed, that you've left "fall through/fallthrough/..."
 comments, which are redundant now. You definitely know better what's more
 readable to you, but after the change these comments really don't add any
 value.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/8476#comment:2>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.