Re: [Boost-bugs] [Boost C++ Libraries] #8032: Warning fixes in circular_buffer

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #8032: Warning fixes in circular_buffer
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2013-11-12 21:25:28

#8032: Warning fixes in circular_buffer
------------------------------------------+-----------------------------
  Reporter:  Franz Detro <franz.detro@…>  |      Owner:  marshall
      Type:  Patches                      |     Status:  closed
 Milestone:  To Be Determined             |  Component:  circular_buffer
   Version:  Boost 1.53.0                 |   Severity:  Cosmetic
Resolution:  fixed                        |   Keywords:
------------------------------------------+-----------------------------

Comment (by pbf@…):

 When building against boost 1.55 using VisualStudio 2010 with warning
 level 4, I now see:

 1>C:\src\svn\OTI\ThirdParty\boost_1_55_0_OT1\include\boost/circular_buffer/base.hpp(199):
 warning C4172: returning address of local variable or temporary

 Likewise, building using gcc 4.4.7 on RedHat produces the following
 warning:

 /media/sf_C_DRIVE/src/svn/OTI/ThirdParty/boost_1_55_0_OT1/include/boost/circular_buffer/base.hpp:2157:
 error: suggest parentheses around ‘&&’ within ‘||’

 The MSVC issue seems to be a regression introduced by the adoption of move
 semantics (ticket #7888), so I'll make the same comment there. I'm
 guessing it's the same case for the gcc warning, although the warning
 itself doesn't make much sense to me, given the line in question is:

 replace(p, this_type::move_if_noexcept(*next));

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/8032#comment:4>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.