Re: [Boost-bugs] [Boost C++ Libraries] #9426: boost::atomic gcc-cas related specializations patch

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #9426: boost::atomic gcc-cas related specializations patch
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2013-11-23 14:55:02

#9426: boost::atomic gcc-cas related specializations patch
-------------------------------------+--------------------------
  Reporter:  Piotr Kobzda <pikob@…>  |      Owner:  timblechmann
      Type:  Patches                 |     Status:  new
 Milestone:  To Be Determined        |  Component:  atomic
   Version:  Boost 1.55.0            |   Severity:  Problem
Resolution:                          |   Keywords:
-------------------------------------+--------------------------

Comment (by andysem):

 I welcome the compilation fixes for the gcc-cas.hpp and cas32strong.hpp
 headers but I don't see the point in the configuration macro. The ARM
 target should use the implementation from gcc-armv6plus.hpp (not lock-
 based). If it doesn't then that's probably a bug in the target detection
 in platform.hpp and I'd prefer it to be fixed instead. gcc-cas.hpp should
 be included only since gcc 4.1, because `__sync*` intrinsics were not
 available before. It should also check if
 `__GCC_HAVE_SYNC_COMPARE_AND_SWAP_N` macros are defined. I suppose, that
 implementation would be used in case of MIPS. In any case, there is no
 need in forcing gcc-cas.hpp, unless I'm missing something.

 PS: I'm not aware of any hidden problems with gcc-cas.hpp. When it's
 compilation problems are fixed I'm in favor of enabling it in
 platform.hpp.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/9426#comment:2>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.