Re: [Boost-bugs] [Boost C++ Libraries] #8070: prefer GetTickCount64 over GetTickCount

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #8070: prefer GetTickCount64 over GetTickCount
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2014-01-28 20:59:04

#8070: prefer GetTickCount64 over GetTickCount
---------------------------+----------------------
  Reporter:  alex@…        |      Owner:  viboes
      Type:  Bugs          |     Status:  reopened
 Milestone:  Boost 1.55.0  |  Component:  thread
   Version:  Boost 1.55.0  |   Severity:  Problem
Resolution:                |   Keywords:
---------------------------+----------------------

Comment (by viboes):

 Replying to [comment:25 raad@…]:
 > _WIN32_WINNT_WS08 is always defined if the windows.h from at least the
 Windows SDK 6.0 is included before Boost.Thread, so the value of
 BOOST_THREAD_WIN32_HAS_GET_TICK_COUNT_64 can now vary in different source
 files depending on include order, which leads to serious bugs.
 >
 > _WIN32_WINNT is the lowest Windows version the software is supposed to
 run on, so defining it as 0x0600 while still wanting to support Windows XP
 is incorrect and boost users should fix their code. Boost.Thread is by far
 not the only library that would drop support for Windows XP when
 _WIN32_WINNT is defined as 0x0600.
 >
 > So if you want a static check for the minimum required Windows version
 at compile time, the check for (_WIN32_WINNT >= 0x0600) was absolutely
 correct. If you want a dynamic check at runtime, you need to call
 GetProcAddress.

 I have no access to a Windows machine now. I would be grateful of could
 you provide a patch that works for any windows release.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/8070#comment:26>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.