Re: [Boost-bugs] [Boost C++ Libraries] #6700: Exceptionless lexical_cast

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #6700: Exceptionless lexical_cast
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2014-01-30 09:40:38

#6700: Exceptionless lexical_cast
-----------------------------------------------+--------------------------
  Reporter:  Olaf van der Spek <olafvdspek@…>  |      Owner:  apolukhin
      Type:  Feature Requests                  |     Status:  reopened
 Milestone:  To Be Determined                  |  Component:  lexical_cast
   Version:  Boost 1.48.0                      |   Severity:  Problem
Resolution:                                    |   Keywords:
-----------------------------------------------+--------------------------

Comment (by apolukhin):

 Replying to [comment:10 Troy Korjuslommi <troykor@…>]:
 > I can post proper tests and docs once this patch gets some positive
 comments. The comments in this ticket seem sufficient for reviewing the
 patch itself.

 Once again: the issue is already resolved in developer branch of Boost.

 > The lexical_cast function doesn't compile with -DBOOST_NO_EXCEPTIONS
 either, and this ticket had no mention of it. I did consider it, but it
 didn't seem to be an concern here. I guess I was wrong. I will see what
 needs to be done.

 You are wrong. `lexical_cast function` '''does''' compile with
 -DBOOST_NO_EXCEPTIONS. See
 [http://www.boost.org/development/tests/develop/developer/conversion.html

 results] for `lexical_cast_no_exceptions_test`. And it compiles for a long
 time!

 > The patch against numeric::converter should be developed independently,
 as it's a separate package. Once it works, try_lexical_cast can be
 modified to call it's non throwing function. That's a one line change.
 >
 > As I see it, the patch solves the issue at hand. Adding the
 -DBOOST_NO_EXCEPTIONS support and calls to modified numeric::converter can
 be added once the basic functionality is approved.

 Once again: the '''issue is already resolved''' in developer branch of
 Boost. It is waiting for regression tests to pass, before merging to
 release. And it is resolved without breaking existing functionality and
 without "let's do it wrong for now".

 If you want to help, try fixing this issue #8261.

 If you want to get some easy money from
 [https://www.bountysource.com/issues/1352296-exceptionless-lexical_cast

 bountysource], then '''do the work right'''! Do the work that is '''not
 finished'''!

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/6700#comment:11>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.