Re: [Boost-bugs] [Boost C++ Libraries] #9378: g++ 4.7 -Wshadow warnings need attention

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #9378: g++ 4.7 -Wshadow warnings need attention
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2014-03-19 03:28:39

#9378: g++ 4.7 -Wshadow warnings need attention
------------------------------------------+--------------------------
  Reporter:  Tom Browder <tom.browder@…>  |      Owner:  eric_niebler
      Type:  Bugs                         |     Status:  new
 Milestone:  To Be Determined             |  Component:  xpressive
   Version:  Boost 1.55.0                 |   Severity:  Problem
Resolution:                               |   Keywords:
------------------------------------------+--------------------------

Comment (by steven_watanabe):

 Warnings are not a problem in themselves.  They are simply the compiler's
 best attempt to guess where there are problems.  Not all warnings are
 appropriate for all coding styles.  Some warnings are usually useful, some
 are useful to some people, and some are almost never useful.  I'll point
 out that -Wshadow is not included in -Wall or even -Wextra.  I'll also say
 that I have fixed -Wshadow warnings in the past.  My experience was that
 it was extremely tedious and found no bugs whatsoever.  I also had to hack
 the documentation toolchain to prevent doxygen from showing the ugly
 mangled names.  I don't consider -Wshadow to be much more useful than if
 the compiler picked a random line of code and said, "warning: there is
 code on this line.  There might be a bug here."  I use warning suppression
 headers because I only have a finite amount of time available and I'd
 rather spend it doing something productive (like improving the test suite)
 than spend it looking at hundreds of messages that only have an
 infinitesimal chance of being a real problem.

 I am not the maintainer of xpressive, of course.  How this is handled is
 ultimately Eric's decision.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/9378#comment:14>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.