Re: [Boost-bugs] [Boost C++ Libraries] #10109: Wrong overflow checking with uint_parser<int>

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #10109: Wrong overflow checking with uint_parser<int>
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2014-06-10 22:38:31

#10109: Wrong overflow checking with uint_parser<int>
----------------------------------------------+---------------------
  Reporter:  Giulio Franco <giulio_franco@…>  |      Owner:  djowel
      Type:  Bugs                             |     Status:  new
 Milestone:  To Be Determined                 |  Component:  spirit
   Version:  Boost Release Branch             |   Severity:  Problem
Resolution:                                   |   Keywords:
----------------------------------------------+---------------------

Comment (by djowel):

 OK, if you have a patch, then I'll consider it. Please post a pull request
 to https://github.com/boostorg/spirit/tree/develop, making sure that all
 the tests pass.

 (Yes, the docs does not give any restrictions on T at the moment, but if
 there's no optimal way to make it work with wrapping ints, then I'm
 inclined to make it an unchecked precondition. T == double is irrelevant
 because double does not wrap. You can also use saturating ints that do not
 wrap, for example).

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/10109#comment:3>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.