[Boost-bugs] [Boost C++ Libraries] #10137: local_free_on_destruction being used but not included on CYGWIN

Subject: [Boost-bugs] [Boost C++ Libraries] #10137: local_free_on_destruction being used but not included on CYGWIN
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2014-06-20 01:11:55

#10137: local_free_on_destruction being used but not included on CYGWIN
-------------------------------------+-------------------------
 Reporter:  eric_niebler             |      Owner:  bemandawes
     Type:  Bugs                     |     Status:  new
Milestone:  Boost 1.56.0             |  Component:  system
  Version:  Boost Development Trunk  |   Severity:  Showstopper
 Keywords:                           |
-------------------------------------+-------------------------
 The following commit broke the cygwin build:
 [https://github.com/boostorg/system/commit/9c23522b739029c12bc2331d654b11289488fabb

 9c23522b]. The use of `local_free_on_destruction`
 [https://github.com/boostorg/system/blob/9c23522b739029c12bc2331d654b11289488fabb/include/boost/system/detail/error_code.ipp#L413

 here] causes an error because `local_free_on_destruction.hpp` is not
 getting included.

 For CYGWIN, we have:

  - `BOOST_WINDOWS_API` is defined
  - `BOOST_PLAT_WINDOWS_DESKTOP` is not

 Examining the config logic at the top of `error_code.ipp`, you'll see that
 `local_free_on_destruction.hpp` will not get included. But the offending
 line gets compiled under these conditions:

  - `BOOST_WINDOWS_API` is defined
  - `BOOST_PLAT_WINDOWS_DESKTOP` is not defined
  - `BOOST_NO_ANSI_APIS` is also not defined (true on all systems except
 WinCE)

 I suggest reverting
 [https://github.com/boostorg/system/commit/9c23522b739029c12bc2331d654b11289488fabb

 9c23522b] and giving the author another crack at it.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/10137>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.