Re: [Boost-bugs] [Boost C++ Libraries] #10354: inconsistent declaration of do_length in boost/detail/utf8_codecvt_facet.hpp due to missing BOOST_WORKAROUND

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #10354: inconsistent declaration of do_length in boost/detail/utf8_codecvt_facet.hpp due to missing BOOST_WORKAROUND
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2014-09-03 21:59:00

#10354: inconsistent declaration of do_length in
boost/detail/utf8_codecvt_facet.hpp due to missing BOOST_WORKAROUND
----------------------------------------------+------------------------
  Reporter:  Juan Alday <alday.boost.trac@…>  |      Owner:  bemandawes
      Type:  Bugs                             |     Status:  closed
 Milestone:  To Be Determined                 |  Component:  filesystem
   Version:  Boost 1.56.0                     |   Severity:  Problem
Resolution:  fixed                            |   Keywords:
----------------------------------------------+------------------------
Changes (by bemandawes):

 * status:  new => closed
 * resolution:   => fixed

Comment:

 Fixed. Thanks!

 Here is the commit message:

 Fix #10354 from Juan Alday. As he pointed out, the declaration (in
 detail/utf8_codecvt_facet.hpp) and definition (in
 detail/utf8_codecvt_facet.ipp) need to use the same signature.

 Reapply Marshall Clow's [SVN r81616] and [SVN r81877] from November and
 December, 2012, as these appear to correctly supply const for the
 msvc/dinkumware library (since fixed) that used a do_length() first
 argument.

 Revert the portion of [SVN r86722] that removed
 BOOST_CODECVT_DO_LENGTH_CONST from the do_length() signature in
 utf8_codecvt_facet.ipp so that it stays in sync with
 utf8_codecvt_facet.hpp. For the same reason, copy the __IBMCPP__
 workaround from utf8_codecvt_facet.ipp to utf8_codecvt_facet.hpp.

 Verified all libraries (filesystem, log, program_options, property_tree,
 serialization) that use utf8_codecvt_facet passed all tests before, and
 then after, these changes.

 Also applied minor edits to the use comments embedded in
 utf8_codecvt_facet.hpp.

 --Beman

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/10354#comment:1>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.