Re: [Boost-bugs] [Boost C++ Libraries] #10545: Bug causing linking problems

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #10545: Bug causing linking problems
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2014-09-26 17:29:42

#10545: Bug causing linking problems
-------------------------------+---------------------------
  Reporter:  jlodos@…          |      Owner:  ramey
      Type:  Bugs              |     Status:  reopened
 Milestone:  To Be Determined  |  Component:  serialization
   Version:  Boost 1.56.0      |   Severity:  Problem
Resolution:                    |   Keywords:
-------------------------------+---------------------------
Changes (by ramey):

 * status:  closed => reopened
 * resolution:  duplicate =>


Old description:

> The implementations of is_whitespace functions in
> basic_text_iprimitive.ipp must be inline.
>
> namespace detail {
>     template<class CharType>
>     bool is_whitespace(CharType c);
>
>     template<>
>     inline bool is_whitespace(char t){
>         return 0 != std::isspace(t);
>     }
>
>     #ifndef BOOST_NO_CWCHAR
>     template<>
>     inline bool is_whitespace(wchar_t t){
>         return 0 != std::iswspace(t);
>     }
>     #endif
> } // detail

New description:

 The implementations of is_whitespace functions in
 basic_text_iprimitive.ipp must be inline.

 namespace detail {
     template<class CharType>
     bool is_whitespace(CharType c);

     template<>
     inline bool is_whitespace(char t){
         return 0 != std::isspace(t);
     }

     #ifndef BOOST_NO_CWCHAR
     template<>
     inline bool is_whitespace(wchar_t t){
         return 0 != std::iswspace(t);
     }
     #endif
 } // detail

 Does the code in your package not show this?

 Robert Ramey

--
Comment:
 my copy of the current code is exactly the code you have above.
 {{{
 namespace detail {
     template<class CharType>
     bool is_whitespace(CharType c);

     template<>
     bool is_whitespace(char t){
         return 0 != std::isspace(t);
     }

     #ifndef BOOST_NO_CWCHAR
     template<>
     bool is_whitespace(wchar_t t){
         return 0 != std::iswspace(t);
     }
     #endif
 } // detail
 }}}
-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/10545#comment:2>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.