Re: [Boost-bugs] [Boost C++ Libraries] #10697: Boost coroutine leaks windows.h into global namespace

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #10697: Boost coroutine leaks windows.h into global namespace
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2014-10-25 13:45:51

#10697: Boost coroutine leaks windows.h into global namespace
-----------------------------+-------------------------------------------
  Reporter:  jarmo.tiitto@…  |      Owner:  olli
      Type:  Bugs            |     Status:  new
 Milestone:  Boost 1.57.0    |  Component:  coroutine
   Version:  Boost 1.56.0    |   Severity:  Problem
Resolution:                  |   Keywords:  windows.h coroutine namespace
-----------------------------+-------------------------------------------

Comment (by olli):

 Replying to [ticket:10697 jarmo.tiitto@…]:
 > I was surprised that file
 "boost/coroutine/windows/protected_stack_allocator.hpp" from coroutine
 library from boost release 1.56.0 version just insanely includes windows.h
 in public header without any protection from the header leaking into
 global namespace severely polluting it.
 >

 ? windows.h is a system header from Windows, it is legitmi to include it
 in windows-related code - I don't know why you say 'insanely' etc.

 > Because of this 'boost/coroutine/protected_stack_allocator.hpp' is
 rendered UNUSABLE/BROKEN on windows (all compilers) and namespace
 pollution may apply to Unix/Linux as well. The feature is released very
 hacky and unfinished way by having such code issues.

 it is protected by '#if defined(BOOST_WINDOWS)' - why should this pollute
 Unix/Linux?
 if you think the library is grap - than don't use it

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/10697#comment:1>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.