Re: [Boost-bugs] [Boost C++ Libraries] #7610: Add support for PSK authentication to boost::asio:ssl

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #7610: Add support for PSK authentication to boost::asio:ssl
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2015-03-06 20:58:00

#7610: Add support for PSK authentication to boost::asio:ssl
---------------------------------------------+----------------------------
  Reporter:  Roman Bovsunovskiy <a2k0001@…>  |      Owner:  chris_kohlhoff
      Type:  Patches                         |     Status:  new
 Milestone:  To Be Determined                |  Component:  asio
   Version:  Boost 1.52.0                    |   Severity:  Optimization
Resolution:                                  |   Keywords:  SSL, TLS, PSK
---------------------------------------------+----------------------------

Comment (by anonymous):

 The patch has a couple of issues with it.  Chiefly the use of
 SSL_ctx_set_app_data and

 SSL_ctx_get_app_data (and SSL_set_app_data in the engine class) assigning
 a different type to

 set_verify_callback.  the type set in verify_callback is the one that is
 destroyed in the context

 dtor.  It will probably still work but it is technically not correct.
 Additionally this would result

 in UB if both verify_callback and psk callbacks are set on the same
 context.

 Should use a small detail__context_appdata class or something.

 This is also missing an interface to set the PSK callback in the client
 case.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/7610#comment:3>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.