Re: [Boost-bugs] [Boost C++ Libraries] #8379: side_by_triangle foils scaled-epsilon for equality by comparing determinant against zero

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #8379: side_by_triangle foils scaled-epsilon for equality by comparing determinant against zero
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2015-03-24 01:23:26

#8379: side_by_triangle foils scaled-epsilon for equality by comparing determinant
against zero
--------------------------------------+---------------------------
  Reporter:  Hubert Tong <hstong@…>   |      Owner:  barendgehrels
      Type:  Bugs                     |     Status:  closed
 Milestone:  Boost 1.58.0             |  Component:  geometry
   Version:  Boost Development Trunk  |   Severity:  Problem
Resolution:  fixed                    |   Keywords:
--------------------------------------+---------------------------
Changes (by awulkiew):

 * status:  new => closed
 * resolution:   => fixed
 * milestone:  To Be Determined => Boost 1.58.0

Comment:

 Thanks for the report!
 It took a while to address it, sorry about that.

 For floating-point numbers, the result is now compared according to the
 machine epsilon scaled by the greatest value passed into the
 `determinant()` formula.

 The results of the determinant are compared this way not only in
 side_by_triangle but also cartesian intersection strategy.

 For the details see:

 -
 https://github.com/boostorg/geometry/commit/b5887efd5e839e0e458bce207a34272cc3193a5c

 -
 https://github.com/boostorg/geometry/commit/f59f6ffaceb6cb36f0b07ae24f01d8790527985c

 -
 https://github.com/boostorg/geometry/commit/dbeb823fcbd8ef5c30f8c2a7f25f3ac2300a0f27


 Any suggestions are welcome!

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/8379#comment:1>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.