[Boost-bugs] [Boost C++ Libraries] #11142: boost::date_time::period_parser::delimiter_strings setter doesn't set values

Subject: [Boost-bugs] [Boost C++ Libraries] #11142: boost::date_time::period_parser::delimiter_strings setter doesn't set values
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2015-03-25 10:21:44

#11142: boost::date_time::period_parser::delimiter_strings setter doesn't set
values
-------------------------------------------+------------------------
 Reporter:  Laurent DORE <laurent.dore@…>  |      Owner:  az_sw_dude
     Type:  Bugs                           |     Status:  new
Milestone:  To Be Determined               |  Component:  date_time
  Version:  Boost 1.57.0                   |   Severity:  Problem
 Keywords:                                 |
-------------------------------------------+------------------------
 The current code for
 {{{boost::date_time::period_parser::delimiter_strings}}} setter is:

 {{{#!cpp
     void delimiter_strings(const string_type& ,
                            const string_type& ,
                            const string_type& ,
                            const string_type& )
     {
       m_period_separator;
       m_period_start_delimeter;
       m_open_range_end_delimeter;
       m_closed_range_end_delimeter;
     }
 }}}

 Up to Boost 1.51, a build with clang caused a warning with the
 {{{-Wunused-parameter}}} option.

 The latest change in
 7b1b5aa452a9c7cc34230c99ac748a542cc23749 does not address the setter
 behavior, but removes the warning.

 The code should probably be:
 {{{#!cpp
     void delimiter_strings(const string_type& separator,
                            const string_type& start_delim,
                            const string_type& open_end_delim,
                            const string_type& closed_end_delim)
     {
       m_period_separator = separator;
       m_period_start_delimeter = start_delim;
       m_open_range_end_delimeter = open_end_delim;
       m_closed_range_end_delimeter = closed_end_delim;
     }
 }}}

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/11142>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.