Re: [Boost-bugs] [Boost C++ Libraries] #11166: boost::filesystem::remove is racy

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #11166: boost::filesystem::remove is racy
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2015-09-01 15:34:56

#11166: boost::filesystem::remove is racy
------------------------------------+------------------------
  Reporter:  Jeff Epler <jepler@…>  |      Owner:  bemandawes
      Type:  Bugs                   |     Status:  closed
 Milestone:  To Be Determined       |  Component:  filesystem
   Version:  Boost 1.57.0           |   Severity:  Problem
Resolution:  fixed                  |   Keywords:
------------------------------------+------------------------
Changes (by bemandawes):

 * status:  new => closed
 * resolution:   => fixed

Comment:

 A change similar to the suggested patch has been applied. It covers the
 same set of error codes used elsewhere to identify the general "file not
 found" case.

 Please note that this change mitigates but does not totally eliminate the
 chance of external file system races.

 It does not protect against multi-threading data races. "Data races are
 bad", to quote Howard Hinnant and a bunch of other experts. For rationale,
 see https://software.intel.com/en-us/blogs/2013/01/06/benign-data-races-

 what-could-possibly-go-wrong

 The test program provide has both a file system race and a data race, so
 it always fails for me (four core CPU, Windows 10, 64-bit system, VC++
 2015, Boost 1.59) because of the data race regardless of anything done to
 mitigate the file system race.

 Thanks for the report, example program, and patch,

 --Beman

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/11166#comment:4>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.