Re: [Boost-bugs] [Boost C++ Libraries] #9518: string_ref::rfind return value offset

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #9518: string_ref::rfind return value offset
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2015-10-18 17:09:06

#9518: string_ref::rfind return value offset
-------------------------------------+---------------------------
  Reporter:  Peter A. Bigot <pab@…>  |      Owner:  no-maintainer
      Type:  Bugs                    |     Status:  new
 Milestone:  To Be Determined        |  Component:  utility
   Version:  Boost 1.55.0            |   Severity:  Problem
Resolution:                          |   Keywords:
-------------------------------------+---------------------------

Comment (by Alex L. <alxlaus@…>):

 In my opinion the proposed fix goes in the wrong direction.  The core of
 the problem lies in the reverse_distance helper, which ought to
 incorporate a more general length of the string as an offset  (currently
 it is hard-coded to "1", which nicely fits the other usages, but not that
 in rfind).

 I created a PR along with a test case here:
 https://github.com/boostorg/utility/pull/21

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/9518#comment:8>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.