Subject: Re: [Boost-bugs] [Boost C++ Libraries] #11632: UB in boost.format basic_oaltstringstream
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2016-01-18 13:47:22
#11632: UB in boost.format basic_oaltstringstream
--------------------------------------+---------------------------
Reporter: rogero@… | Owner: samuel_krempp
Type: Bugs | Status: new
Milestone: To Be Determined | Component: format
Version: Boost Development Trunk | Severity: Problem
Resolution: | Keywords:
--------------------------------------+---------------------------
Comment (by anonymous):
Hmmm... I've applied the following patch:
{{{
diff -Naur alt_sstream.hpp.orig alt_sstream.hpp
--- alt_sstream.hpp.orig 2015-12-11 11:21:50.000000000 +0100
+++ alt_sstream.hpp 2016-01-18 10:46:39.000000000 +0100
@@ -137,13 +137,13 @@
public:
typedef Alloc allocator_type;
basic_oaltstringstream()
- : pbase_type(new stringbuf_t), stream_t(rdbuf())
+ : pbase_type(new stringbuf_t),
stream_t(pbase_type::member.get())
{ }
basic_oaltstringstream(::boost::shared_ptr<stringbuf_t> buf)
- : pbase_type(buf), stream_t(rdbuf())
+ : pbase_type(buf), stream_t(pbase_type::member.get())
{ }
basic_oaltstringstream(stringbuf_t * buf)
- : pbase_type(buf, No_Op() ), stream_t(rdbuf())
+ : pbase_type(buf, No_Op() ),
stream_t(pbase_type::member.get())
{ }
stringbuf_t * rdbuf() const
{ return pbase_type::member.get(); }
}}}
The first instance of undefined behavior was indeed no longer there, but
now I get a different, slightly modified backtrace:
{{{
ASAN:SIGSEGV
=================================================================
==20533==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000
(pc 0x7f28b5b56110 bp 0x7ffda52eb000 sp 0x7ffda52eab50 T0)
#0 0x7f28b5b5610f in __dynamic_cast (/usr/lib/x86_64-linux-
gnu/libstdc++.so.6+0x6610f)
#1 0x7f28b4deabcf (/usr/lib/x86_64-linux-gnu/libubsan.so.0+0x9bcf)
#2 0x7f28b4dea132 (/usr/lib/x86_64-linux-gnu/libubsan.so.0+0x9132)
#3 0x7f28b4dea892 in __ubsan_handle_dynamic_type_cache_miss
(/usr/lib/x86_64-linux-gnu/libubsan.so.0+0x9892)
#4 0x7f28b9b1759b in boost_1_57_0::io::basic_oaltstringstream<char,
std::char_traits<char>, std::allocator<char>
>::basic_oaltstringstream(boost_1_57_0::io::basic_altstringbuf<char,
std::char_traits<char>, std::allocator<char> >*)
(/build/debug/cpp/libotdscpp.so+0x3d1a59b)
#5 0x7f28b9b0cc0a in void boost_1_57_0::io::detail::put<char,
std::char_traits<char>, std::allocator<char>,
boost_1_57_0::io::detail::put_holder<char, std::char_traits<char> >
const&>(boost_1_57_0::io::detail::put_holder<char, std::char_traits<char>
> const&, boost_1_57_0::io::detail::format_item<char,
std::char_traits<char>, std::allocator<char> > const&,
boost_1_57_0::basic_format<char, std::char_traits<char>,
std::allocator<char> >::string_type&, boost_1_57_0::basic_format<char,
std::char_traits<char>, std::allocator<char> >::internal_streambuf_t&,
std::locale*) (/build/debug/cpp/libotdscpp.so+0x3d0fc0a)
#6 0x7f28b9aff54f in void boost_1_57_0::io::detail::distribute<char,
std::char_traits<char>, std::allocator<char>,
boost_1_57_0::io::detail::put_holder<char, std::char_traits<char> >
const&>(boost_1_57_0::basic_format<char, std::char_traits<char>,
std::allocator<char> >&, boost_1_57_0::io::detail::put_holder<char,
std::char_traits<char> > const&)
lib/boost/install/include/boost/format/feed_args.hpp:285
#7 0x7f28b9af37c0 in boost_1_57_0::basic_format<char,
std::char_traits<char>, std::allocator<char> >&
boost_1_57_0::io::detail::feed_impl<char, std::char_traits<char>,
std::allocator<char>, boost_1_57_0::io::detail::put_holder<char,
std::char_traits<char> > const&>(boost_1_57_0::basic_format<char,
std::char_traits<char>, std::allocator<char> >&,
boost_1_57_0::io::detail::put_holder<char, std::char_traits<char> >
const&) lib/boost/install/include/boost/format/feed_args.hpp:295
#8 0x7f28ba15ed60 in boost_1_57_0::basic_format<char,
std::char_traits<char>, std::allocator<char> >&
boost_1_57_0::io::detail::feed<char, std::char_traits<char>,
std::allocator<char>, char const (&)
[27]>(boost_1_57_0::basic_format<char, std::char_traits<char>,
std::allocator<char> >&, char const (&) [27])
lib/boost/install/include/boost/format/feed_args.hpp:307
#9 0x7f28ba159694 in boost_1_57_0::basic_format<char,
std::char_traits<char>, std::allocator<char> >&
boost_1_57_0::basic_format<char, std::char_traits<char>,
std::allocator<char> >::operator%<char [27]>(char const (&) [27])
lib/boost/install/include/boost/format/format_class.hpp:64
}}}
{{{
$ g++-5 -v
Using built-in specs.
COLLECT_GCC=/usr/bin/g++-5
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/5/lto-wrapper
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu
5.3.0-3ubuntu1~14.04' --with-
bugurl=file:///usr/share/doc/gcc-5/README.Bugs --enable-
languages=c,ada,c++,java,go,fortran,objc,obj-c++ --prefix=/usr --program-
suffix=-5 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib
--without-included-gettext --enable-threads=posix --libdir=/usr/lib
--enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-
debug --enable-libstdcxx-time=yes --with-default-libstdcxx-
abi=gcc4-compatible --disable-libstdcxx-dual-abi --enable-gnu-unique-
object --disable-vtable-verify --enable-libmpx --enable-plugin --with-
system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-
cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-5-amd64/jre --enable-
java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-5-amd64 --with-
jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-5-amd64 --with-arch-
directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-
objc-gc --enable-multiarch --disable-werror --with-arch-32=i686 --with-
abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-
tune=generic --enable-checking=release --build=x86_64-linux-gnu
--host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 5.3.0 20151204 (Ubuntu 5.3.0-3ubuntu1~14.04)
}}}
Any ideas?
-- Ticket URL: <https://svn.boost.org/trac/boost/ticket/11632#comment:4> Boost C++ Libraries <http://www.boost.org/> Boost provides free peer-reviewed portable C++ source libraries.
This archive was generated by hypermail 2.1.7 : 2017-02-16 18:50:19 UTC