[Boost-bugs] [Boost C++ Libraries] #12358: epoll_reactor calls fcntl without checking return code

Subject: [Boost-bugs] [Boost C++ Libraries] #12358: epoll_reactor calls fcntl without checking return code
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2016-07-29 12:12:09

#12358: epoll_reactor calls fcntl without checking return code
------------------------------+----------------------------
 Reporter:  jim.king@…        |      Owner:  chris_kohlhoff
     Type:  Bugs              |     Status:  new
Milestone:  To Be Determined  |  Component:  asio
  Version:  Boost 1.54.0      |   Severity:  Problem
 Keywords:                    |
------------------------------+----------------------------
 From lines 469 to 473 of epoll_reactor.ipp:

 {{{
   if (fd == -1 && (errno == EINVAL || errno == ENOSYS))
   {
     fd = epoll_create(epoll_size);
     if (fd != -1)
       ::fcntl(fd, F_SETFD, FD_CLOEXEC);
   }
 }}}

 This is at least as far back as 1.54 however it is present in the
 development trunk too.  Should this fcntl fail for some reason, what is
 the correct behavior?

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/12358>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.