Re: [Boost-bugs] [Boost C++ Libraries] #12388: useless static const generated by BOOST_SPIRIT_DEFINE_?

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #12388: useless static const generated by BOOST_SPIRIT_DEFINE_?
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2016-08-10 19:24:19

#12388: useless static const generated by BOOST_SPIRIT_DEFINE_?
-------------------------------+----------------------
  Reporter:  cppljevans@…      |      Owner:
      Type:  Bugs              |     Status:  new
 Milestone:  To Be Determined  |  Component:  None
   Version:  Boost 1.61.0      |   Severity:  Cosmetic
Resolution:                    |   Keywords:
-------------------------------+----------------------

Comment (by cppljevans@…):

 Replying to [ticket:12388 cppljevans@…]:
 > The purpose of creating of a static variable here:
 >
 >
 https://github.com/boostorg/spirit/blob/develop/include/boost/spirit/home/x3/nonterminal/rule.hpp#L164

 >
 > is not apparent.  Why wouldn't the following replacement:
 >
 >   auto const& def_=BOOST_PP_CAT(rule_name, _def);
 >
 > work just as well.  If not, some source code comments explaining the
 need for
 > creating a new instance of a struct would help maintainers and people
 > trying to understand the code.

 Closer inspection of rule_definition shows it handles attributes.
 Sorry for noise.
 Please ignore this ticket.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/12388#comment:1>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.