Re: [Boost-bugs] [Boost C++ Libraries] #12402: knowing the current filename used by a boost.log text_file_backend

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #12402: knowing the current filename used by a boost.log text_file_backend
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2016-08-22 13:57:35

#12402: knowing the current filename used by a boost.log text_file_backend
----------------------------------------------+----------------------------
  Reporter:  Philip Miller <philip.miller@…>  |      Owner:  andysem
      Type:  Feature Requests                 |     Status:  new
 Milestone:  To Be Determined                 |  Component:  log
   Version:  Boost 1.60.0                     |   Severity:  Problem
Resolution:                                   |   Keywords:
                                              |  text_file_backend
----------------------------------------------+----------------------------

Comment (by Philip Miller <philip.miller@…>):

 I have modified text_file_backend so that it meets my requirements. I did
 this by:
 1. adding to the open and close handler a string argument for the filename
 of the stream; the stream filename is  readily available from
 m_pImpl->m_FileName where the open and close handlers are called by
 text_file_backend::consume and text_file_backend::close_file.
 2. adding to the collector interface a set_store_handler callback method
 that the file_collector implements so it may use the callback in its
 implementation of the store_file method.

 Right now I have put these changes in a copy of text_file_backend that I
 have incorporated into the source code of my local project. If you are
 interested, I can put these changes into a pull request for Boost.Log. As
 far as I can see, the changes are quite small and seem to fit in well with
 your text_file_backend implementation. Unfortunately, change (1), modifies
 the current text_file_backend open and close _handler_type types, so it
 will affect compatibility. I am not sure how, if at all, you want to deal
 with API changes.

 I do, however, think the improved functionality my changes provide are
 important. Without these changes, I cannot meet either of my requirements.
 I would like to get this functionality into a future Boost.Log release as
 I do not like either choice of maintaining my own hacked copy of
 text_file_backend, or my own distribution of boost.

 Thanks for all of your effort on Boost.Log!

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/12402#comment:2>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.