[Boost-bugs] [Boost C++ Libraries] #13142: circle_formation_functor call has no effect?

Subject: [Boost-bugs] [Boost C++ Libraries] #13142: circle_formation_functor call has no effect?
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2017-07-29 20:25:40

#13142: circle_formation_functor call has no effect?
------------------------------+------------------------------
 Reporter:  nkurtov@…         |      Owner:  Lucanus Simonson
     Type:  Bugs              |     Status:  new
Milestone:  To Be Determined  |  Component:  polygon
  Version:  Boost 1.64.0      |   Severity:  Optimization
 Keywords:                    |
------------------------------+------------------------------
 What effect has the call of circle_formation_functor_.ppp() in
 boost::polygon::detail::circle_formation_predicate::operator() ?
 The call seems to have no side effects, because circle_formation_functor_
 is stateless and it does not affect voronoi_builder or voronoi_diagram.
 Is it safe to simply delete the call?

 http://www.boost.org/doc/libs/1_64_0/boost/polygon/detail/voronoi_predicates.hpp

 class circle_formation_predicate {
   bool operator()(const site_type& site1, const site_type& site2,
                   const site_type& site3, circle_type& circle) {
     if (!site1.is_segment()) {
       if (!site2.is_segment()) {
         if (!site3.is_segment()) {
           // (point, point, point) sites.
           if (!circle_existence_predicate_.ppp(site1, site2, site3))
             return false;
           circle_formation_functor_.ppp(site1, site2, site3, circle);  //
 <- This call has no effect, does it?

-- 
Ticket URL: <https://svn.boost.org/trac10/boost/ticket/13142>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.