Re: [Boost-bugs] [Boost C++ Libraries] #4014: [PATCH] boost/gil gcc warning cleanup

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #4014: [PATCH] boost/gil gcc warning cleanup
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2018-08-25 07:57:20

#4014: [PATCH] boost/gil gcc warning cleanup
--------------------------------------------+----------------------------
  Reporter:  Tatu Kilappa <tatu.kilappa@…>  |      Owner:  Stefan Seefeld
      Type:  Patches                        |     Status:  closed
 Milestone:  Boost 1.43.0                   |  Component:  gil USE GITHUB
   Version:  Boost Development Trunk        |   Severity:  Cosmetic
Resolution:  fixed                          |   Keywords:  gcc warning
--------------------------------------------+----------------------------
Changes (by Mateusz Loskot):

 * status:  new => closed
 * resolution:   => fixed

Comment:

 Most of the warnings cleaned by the patch are -Wshadow diagnostics for
 constructor parameter/class member of the same name. Use of the same
 constructor parameter/class member names is fine C++ and I don't think we
 need any changes here.

 I attached complete build log generated by `b2 toolset=gcc` using GCC 7.3
 and all the compilation flags suggested by the ticket's reporter and I no
 longer see any

 `warning: declaration of ... shadows a member of...`

 related to the suggested patch.

 As for the `io_error` function, it also seems no longer necessary.
 BTW, GIL in Boost 1.68 delivers completely re-implemented I/O extensions.
 The new version does provide custom error_exit which does not call hard
 exit() to abort the application, so the issue should be gone now.

 Closing as fixed.

 github ref: https://github.com/boostorg/gil/projects/4#card-12435867

-- 
Ticket URL: <https://svn.boost.org/trac10/ticket/4014#comment:4>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.