Re: [jamboost] Build request interface

From: Vladimir Prus (ghost_at_[hidden])
Date: 2002-07-01 09:52:23

David Abrahams wrote:
> ----- Original Message -----
> From: "Vladimir Prus" <ghost_at_[hidden]>
>
> > > I hate adding new global variables. Can we do it with ALWAYS and/or
> > > TOUCH/UNTOUCH rules? If that gets too messy, I agree we should just go
>
> with
>
> > > the variable.
> >
> > IMO, we really need to allow changing the set of target where traversal
> > begings. NoUpdate can be used to remove elements from there. But to add
> > elements to the set we'd need either the variable or a new builtin.
>
> OK, fine with me. I trust your judgement on this.

I've almost done with it. I've implemented a new builtin, tentatively called 
"UPDATE" which causes target to behave as if they were specified in the 
command line. To test, apply the attached patch, and then run 

bjam -ftest -d+12 another

You'll see "all" in the dependency graph, while it is not there without 
"UPDATE all" line in "test". 

I'll commit the change after some more testing. 

> > See jam.c, lines 407-410 for the part that should be changed.
>
> Why don't you just go ahead and make the changes?

Was going to do that, actually. I gave the line numbers so that you can refer 
to the jam's logic in case you don't remember it. 

In fact, I think that Jam's terms are wierd. ALWAYS rule should be called 
"TOUCH" while my new UPDATE rule should be called ALWAYS. 
But we can't change that, for sure!

> BTW, I'm working on the path minimization stuff now. Give me a couple of
> hours...

This is very good. As for me, I planned to finish getting buld request from 
command line today... but spend too long time arguing with a colleague about 
proper development process :-)

- Volodya
 --------------Boundary-00=_BZRK9S1NKYSU0IAVS8TS Content-Type: text/x-diff;
charset="koi8-r";
name="update_rule.diff"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="update_rule.diff"

SW5kZXg6IGJ1aWx0aW5zLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2c3Jvb3QvYm9vc3QvYm9v
c3QvdG9vbHMvYnVpbGQvamFtX3NyYy9idWlsdGlucy5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAx
LjkKZGlmZiAtdSAtcjEuOSBidWlsdGlucy5jCi0tLSBidWlsdGlucy5jCTggTWF5IDIwMDIgMTM6
NTI6NTAgLTAwMDAJMS45CisrKyBidWlsdGlucy5jCTEgSnVsIDIwMDIgMTQ6NDI6MTEgLTAwMDAK
QEAgLTEzNyw2ICsxMzcsOCBAQAogCiAgICAgICBiaW5kX2J1aWx0aW4oICJSTU9MRCIgLCBidWls
dGluX2ZsYWdzLCBUX0ZMQUdfUk1PTEQsIDAgKTsKIAorICAgICAgYmluZF9idWlsdGluKCAiVVBE
QVRFIiwgYnVpbHRpbl91cGRhdGUsIDAsIDAgKTsKKwogICAgICAgewogICAgICAgICAgIGNoYXIg
KiBhcmdzW10gPSB7ICJzdHJpbmciLCAicGF0dGVybiIsICJyZXBsYWNlbWVudHMiLCAiKyIsIDAg
fTsKICAgICAgICAgICBkdXBsaWNhdGVfcnVsZSggInN1YnN0IiAsCkBAIC02NjAsNiArNjYyLDE4
IEBACiBidWlsdGluX3B3ZCggUEFSU0UgKnBhcnNlLCBGUkFNRSAqZnJhbWUgKQogewogICAgIHJl
dHVybiBwd2QoKTsKK30KKworLyoKKyAqIE1ha2VzIHRoZSB0YXJnZXQgdXBkYXRlZCByZWdhcmRs
ZXNzIG9mIHdoZXRoZXIgaXQgb3IgYW55IGFub3RoZXIgdGFyZ2V0IGlzCisgKiBzcGVjaWZpZWQg
aW4gdGhlIGNvbW1hbmQgbGluZS4KKyAqLworTElTVCogCitidWlsdGluX3VwZGF0ZSggUEFSU0Ug
KnBhcnNlLCBGUkFNRSAqZnJhbWUpCit7CisgICAgTElTVCogYXJnMSA9IGxvbF9nZXQoIGZyYW1l
LT5hcmdzLCAwICk7CisgICAgZm9yICggOyBhcmcxOyBhcmcxID0gbGlzdF9uZXh0KCBhcmcxICkg
KQorICAgICAgICBtYXJrX2Fsd2F5c191cGRhdGVkKCBhcmcxLT5zdHJpbmcgKTsKIH0KIAogc3Rh
dGljIHZvaWQgbG9sX2J1aWxkKCBMT0wqIGxvbCwgY2hhcioqIGVsZW1lbnRzICkKSW5kZXg6IGJ1
aWx0aW5zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2c3Jvb3QvYm9vc3QvYm9vc3QvdG9vbHMv
YnVpbGQvamFtX3NyYy9idWlsdGlucy5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjQKZGlmZiAt
dSAtcjEuNCBidWlsdGlucy5oCi0tLSBidWlsdGlucy5oCTMwIE1hciAyMDAyIDEyOjUzOjUwIC0w
MDAwCTEuNAorKysgYnVpbHRpbnMuaAkxIEp1bCAyMDAyIDE0OjQyOjExIC0wMDAwCkBAIC0yOSw1
ICsyOSw2IEBACiBMSVNUICpidWlsdGluX2NhbGxlcl9tb2R1bGUoIFBBUlNFICpwYXJzZSwgRlJB
TUUgKmFyZ3MgKTsKIExJU1QgKmJ1aWx0aW5fYmFja3RyYWNlKCBQQVJTRSAqcGFyc2UsIEZSQU1F
ICphcmdzICk7CiBMSVNUICpidWlsdGluX3B3ZCggUEFSU0UgKnBhcnNlLCBGUkFNRSAqYXJncyAp
OworTElTVCAqYnVpbHRpbl91cGRhdGUoIFBBUlNFICpwYXJzZSwgRlJBTUUgKmFyZ3MgKTsKIAog
I2VuZGlmCkluZGV4OiBtYWtlLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2c3Jvb3QvYm9vc3Qv
Ym9vc3QvdG9vbHMvYnVpbGQvamFtX3NyYy9tYWtlLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEu
NgpkaWZmIC11IC1yMS42IG1ha2UuYwotLS0gbWFrZS5jCTI4IE1heSAyMDAyIDIwOjM1OjEyIC0w
MDAwCTEuNgorKysgbWFrZS5jCTEgSnVsIDIwMDIgMTQ6NDI6MTEgLTAwMDAKQEAgLTcyMywzICs3
MjMsMTUgQEAKIAogCXJldHVybiByZXN1bHQ7CiB9CisKK3N0YXRpYyBMSVNUICphbHdheXNfdXBk
YXRlZF90YXJnZXRzID0gMDsKKwordm9pZCBtYXJrX2Fsd2F5c191cGRhdGVkKGNoYXIgKnRhcmdl
dCkKK3sKKyAgICBhbHdheXNfdXBkYXRlZF90YXJnZXRzID0gbGlzdF9uZXcoIGFsd2F5c191cGRh
dGVkX3RhcmdldHMsIHRhcmdldCApOworfQorCitMSVNUICphbHdheXNfdXBkYXRlZCgpCit7Cisg
ICAgcmV0dXJuIGFsd2F5c191cGRhdGVkX3RhcmdldHM7Cit9CkluZGV4OiBtYWtlLmgKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQpSQ1MgZmlsZTogL2N2c3Jvb3QvYm9vc3QvYm9vc3QvdG9vbHMvYnVpbGQvamFtX3NyYy9t
YWtlLmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMgpkaWZmIC11IC1yMS4yIG1ha2UuaAotLS0g
bWFrZS5oCTYgTm92IDIwMDEgMTU6MzY6MTYgLTAwMDAJMS4yCisrKyBtYWtlLmgJMSBKdWwgMjAw
MiAxNDo0MjoxMSAtMDAwMApAQCAtOCw1ICs4LDE4IEBACiAgKiBtYWtlLmggLSBicmluZyBhIHRh
cmdldCB1cCB0byBkYXRlLCBvbmNlIHJ1bGVzIGFyZSBpbiBwbGFjZQogICovCiAKKyNpbmNsdWRl
ICJsaXN0cy5oIgorCiBpbnQgbWFrZSggaW50IG5fdGFyZ2V0cywgY2hhciAqKnRhcmdldHMsIGlu
dCBhbnlob3cgKTsKIGludCBtYWtlMSggVEFSR0VUICp0ICk7CisKKy8qCisgKiBBZGRzIHRoZSB0
YXJnZXQgdG8gdGhlIGxpc3Qgb2YgYWx3YXlzIHVwZGF0ZWQgb25lcy4gQW4gYXR0ZW1wdCB0bwor
ICogdXBkYXRlIGl0IGlzIHBlcmZvcm1lZCBldmVuIGlmIHRhcmdldHMgYXJlIGV4cGxpY2l0bHkg
c3BlY2lmaWVkIAorICogaW4gdGhlIGNvbW1hbmQgbGlzdC4KKyAqLwordm9pZCBtYXJrX2Fsd2F5
c191cGRhdGVkKGNoYXIgKnRhcmdldCk7CisvKiAKKyAqIFJldHVybnMgdGhlIGxpc3Qgb2YgYWxs
IHRoZSB0YXJnZXQgcHJldmlvdXNseSBwYXNzZWQgdG8gJ21hcmtfYWx3YXlzX3VwZGF0ZWQnLgor
ICovCitMSVNUICphbHdheXNfdXBkYXRlZCgpOwpJbmRleDogamFtLmMKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg
ZmlsZTogL2N2c3Jvb3QvYm9vc3QvYm9vc3QvdG9vbHMvYnVpbGQvamFtX3NyYy9qYW0uYyx2CnJl
dHJpZXZpbmcgcmV2aXNpb24gMS4xMwpkaWZmIC11IC1yMS4xMyBqYW0uYwotLS0gamFtLmMJNSBK
dW4gMjAwMiAxMzozODoxNyAtMDAwMAkxLjEzCisrKyBqYW0uYwkxIEp1bCAyMDAyIDE0OjQyOjEy
IC0wMDAwCkBAIC00MDQsMTAgKzQwNCwyNiBAQAogCiAgICAgLyogTm93IG1ha2UgdGFyZ2V0ICov
CiAKLSAgICBpZiggIWFyZ2MgKQotICAgICAgICBzdGF0dXMgfD0gbWFrZSggMSwgJmFsbCwgYW55
aG93ICk7Ci0gICAgZWxzZQotICAgICAgICBzdGF0dXMgfD0gbWFrZSggYXJnYywgYXJndiwgYW55
aG93ICk7CisgICAgaWYoICFhcmdjICkgCisgICAgICAgIG1hcmtfYWx3YXlzX3VwZGF0ZWQoImFs
bCIpOworCisgICAgeworICAgICAgICBMSVNUKiBleHRyYV90YXJnZXRzID0gYWx3YXlzX3VwZGF0
ZWQoKTsKKyAgICAgICAgaW50IHRhcmdldHNfY291bnQgPSBhcmdjICsgbGlzdF9sZW5ndGgoZXh0
cmFfdGFyZ2V0cyk7CisgICAgICAgIGNoYXIgKip0YXJnZXRzID0gKGNoYXIgKiopbWFsbG9jKHRh
cmdldHNfY291bnQgKiBzaXplb2YoY2hhciAqKSk7CisgICAgICAgIGZvciAoIG47IG4gPCBhcmdj
OyBuKysgKQorICAgICAgICB7CisgICAgICAgICAgICB0YXJnZXRzW25dID0gYXJndltuXTsKKyAg
ICAgICAgfQorICAgICAgICBmb3IgKCA7IGV4dHJhX3RhcmdldHM7IGV4dHJhX3RhcmdldHMgPSBs
aXN0X25leHQoZXh0cmFfdGFyZ2V0cykgKQorICAgICAgICB7CisgICAgICAgICAgICB0YXJnZXRz
W24rK10gPSBleHRyYV90YXJnZXRzLT5zdHJpbmc7CisgICAgICAgIH0KKyAgICAgICAKKyAgICAg
ICAgc3RhdHVzIHw9IG1ha2UoIHRhcmdldHNfY291bnQsIHRhcmdldHMsIGFueWhvdyApOworICAg
ICAgICBmcmVlKHRhcmdldHMpOworICAgIH0KKwogCiAgICAgaWYgKCBERUJVR19QUk9GSUxFICkK
ICAgICAgICAgcHJvZmlsZV9kdW1wKCk7Cg==
 --------------Boundary-00=_BZRK9S1NKYSU0IAVS8TS Content-Type: text/plain;
charset="koi8-r";
name="test"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="test"

Ck5PVEZJTEUgYWxsIGFub3RoZXIgOwpVUERBVEUgYWxsIDs=
 --------------Boundary-00=_BZRK9S1NKYSU0IAVS8TS--