[Christopher Seiwald <[e-mail]>] Re: [jamming] INCLUDES bug?

From: David Abrahams (dave_at_[hidden])
Date: 2002-12-10 05:27:19

I guess we'll have to integrate this patch at some point...

 --=-=-= Content-Type: message/rfc822
Content-Disposition: inline

X-From-Line: seiwald_at_[hidden] Tue Dec 10 00:59:25 2002
Return-Path: <jamming-admin_at_[hidden]>
Received: from 207.172.4.23 (207.172.4.23 [207.172.4.23])
by ms04.mrf.mail.rcn.net (Mirapoint Messaging Server MOS 3.2.2-GA FastPath
queued)
with ESMTP id AEX61388;
Tue, 10 Dec 2002 04:05:05 -0500 (EST)
Received: from mx07.mrf.mail.rcn.net (mx07.mrf.mail.rcn.net [207.172.4.56])
by mr04.mrf.mail.rcn.net (Mirapoint Messaging Server MOS 3.2.2-GA)
with ESMTP id AKK29368;
Tue, 10 Dec 2002 04:05:04 -0500 (EST)
Received: from wireless.perforce.com ([209.209.60.41]
helo=frankenrouter.perforce.com)
by mx07.mrf.mail.rcn.net with esmtp (Exim 3.35 #4)
id 18LgK7-0006va-00
for david.abrahams_at_[hidden]; Tue, 10 Dec 2002 04:05:03 -0500
Received: from fxp1 (localhost [127.0.0.1])
by frankenrouter.perforce.com (8.12.1/8.11.6) with ESMTP id gBA91NPM003483;
Tue, 10 Dec 2002 01:01:23 -0800 (PST)
(envelope-from jamming-admin_at_[hidden])
Received: from computer.perforce.com (computer.perforce.com [10.0.0.197])
by frankenrouter.perforce.com (8.12.1/8.11.6) with ESMTP id gBA8xQPM003447
for <_jamming_at_[hidden]>; Tue, 10 Dec 2002 00:59:26 -0800
(PST)
(envelope-from jamming-admin_at_[hidden])
Received: (from seiwald_at_localhost)
by computer.perforce.com (8.11.6/8.11.6) id gBA8xPQ38451
for jamming_at_[hidden]; Tue, 10 Dec 2002 00:59:25 -0800 (PST)
(envelope-from seiwald)
From: Christopher Seiwald <seiwald_at_[hidden]>
Message-Id: <200212100859.gBA8xPQ38451_at_[hidden]>
To: jamming_at_[hidden]
Subject: Re: [jamming] INCLUDES bug?
In-Reply-To: <200211230535.AAA15164_at_[hidden]>
Sender: jamming-admin_at_[hidden]
Errors-To: jamming-admin_at_[hidden]
X-BeenThere: jamming_at_[hidden]
X-Mailman-Version: 2.0.4
Precedence: bulk
List-Help: <mailto:jamming-request_at_[hidden]?subject=help>
List-Post: <mailto:jamming_at_[hidden]>
List-Subscribe: <http://maillist.perforce.com/mailman/listinfo/jamming>,
<mailto:jamming-request_at_[hidden]?subject=subscribe>
List-Id: Discuss the build tool Jam/MR with other users
<jamming.perforce.com>
List-Unsubscribe: <http://maillist.perforce.com/mailman/listinfo/jamming>,
<mailto:jamming-request_at_[hidden]?subject=unsubscribe>
List-Archive: <http://maillist.perforce.com/pipermail/jamming/>
Date: Tue, 10 Dec 2002 00:59:25 -0800 (PST)
X-Content-Length: 1350
Lines: 46
Xref: NEFARIOUS mail.misc:13742
MIME-Version: 1.0

Steve said:

| With the following Jamfile
|
| actions Make
| {
| touch $(1)
| }
| 
| Make a ;
| Make b ;
| 
| DEPENDS a : b ;
| INCLUDES b : c ;
|
| My expectation is that jam would be able to make 'b', but would refuse to 
| make 'a' for lack of 'c'. Instead, jam refuses to make 'b' for lack of 'c'. 
| Is this a bug?

I said:

> This INCLUDES problem is indeed a bug. 
> ...
> I'm toying with two possible fixes, one that is a fairly
> light bandaide and another that is a deeper reworking of INCLUDES handling.
> If I'm happy with either of them, I'll put the attempt in my path in the
> public depot.

I did the deeper reworking; from the RELNOTES:

Fix 'includes' support so that included files aren't treated as
direct dependencies during the command execution phase. If an
included file failed to build, make1() would bypass the including
file. Now make0() appends each child's 'includes' onto its own
'depends' list, eliminating 'includes'-specific code in make0()
and make1().

It's bundled with a bunch of other changes since 2.4 and can be seen at:

http://public.perforce.com:8080/@md=d@//guest/christopher_seiwald/?ac=83

Christopher
_______________________________________________
jamming mailing list - jamming_at_[hidden]
http://maillist.perforce.com/mailman/listinfo/jamming

 --=-=-= 

-- 
David Abrahams
dave_at_[hidden] * http://www.boost-consulting.com
Boost support, enhancements, training, and commercial distribution
 --=-=-=--