Re: [Boost-build] CVS: boost/tools/build/new feature.jam,1.39,1.40

From: David Abrahams (gclbb-jamboost_at_[hidden])
Date: 2003-05-15 18:11:36

Vladimir Prus <ghost_at_[hidden]> writes:

> David Abrahams wrote:
>
>> > Why, when merging "foo/bar" with "baz" we look at past-the-end symbol of
>> > "foo/bar" in hope that the right separator will be there?
>>
>> Because it's simple and it gives the right result most of the time.
>> Can you propose a better rule?
>
> No. But comment should be better... see bellow.
>
>> > I believe that relies on the assumption that pointers in _pathname
>> > struct all refer to original filename
>>
>> Not exactly. It just is only attempting to handle those cases where
>> the user will be completely astonished that a slash direction has
>> changed.
>
> I'll rephrase: a person who looks at path_build as it is now has no idea how
> the path-the end symbol can be slash. A comment that in most cases the 
> directory comes from path_parse, which leaves the original path separator
> as past-the-end symbol, would help to understand your change.

Sounds good to me.

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com