Re: [jamboost] search_for_target question

From: Vladimir Prus (ghost_at_[hidden])
Date: 2003-12-10 01:19:42

gLeonid wrote:
> Hi.
>
> I am looking at the source code for boost jam from boost-build-2.0-
> m9.1.zip
> In rules.c there is a function called search_for_target question.
>
> This function is using hashtable 'located_targets'.
> It looks like this hash table is always empty, since there is no
> calls of 'hashcheck' to this hash table.
>
> Can you please tell me if this hash table was an accidental by
> product of copy and paste from search.c and should be removed from
> the source code along with LOCATED_TARGET structure, or at line 246
> it should read something like this:
>
> if( hashenter( located_targets, (HASHDATA **)&lta ) )
> {
> memset( (char *)t, '\0', sizeof( *lta ) );
> t->file_name = newstr(result->boundname) ;
> t->target = result;
> }

I think the situation is even more interesting. The 'search_for_target' is 
only called from 'builiin_search_for_target', which implements 
SEARCH_FOR_TARGET builtin. This builtin was used some time ago, but is not 
longer used, so I believe both builtin and search_for_target should be 
removed.

- Volodya