Re: [jamboost] Re: [Boost-build] CVS: boost/tools/build/v1 borland-tools.jam,1.29,1.30

From: Rene Rivera (grafik.list_at_[hidden])
Date: 2003-12-14 15:04:50

David Abrahams wrote:

> Rene Rivera <grafik.list_at_[hidden]> writes:
> 
> 
>>David Abrahams wrote:
>>
>>>Update of /cvsroot/boost/boost/tools/build/v1
>>>In directory sc8-pr-cvs1:/tmp/cvs-serv11172
>>>
>>>Modified Files:
>>>	borland-tools.jam 
>>>Log Message:
>>>quote appended paths
>>>
>>>
>>>Index: borland-tools.jam
>>>===================================================================
>>>RCS file: /cvsroot/boost/boost/tools/build/v1/borland-tools.jam,v
>>>retrieving revision 1.29
>>>retrieving revision 1.30
>>>diff -u -d -r1.29 -r1.30
>>>--- borland-tools.jam	20 Nov 2003 21:43:49 -0000	1.29
>>>+++ borland-tools.jam	13 Dec 2003 15:09:27 -0000	1.30
>>>@@ -118,7 +118,7 @@
>>> {
>>> actions borland-Link-action 
>>> {
>>>- set PATH=$(BCC_TOOL_PATH);%PATH%
>>>+ set PATH=$(BCC_TOOL_PATH);"%PATH%"
>>
>>I'm not sure that change works in all circumstances... It would give incorrect 
>>results if there are multiple paths in the PATH already. 
> 
> 
> Example? Do you mean "spaces in BCC_TOOL_PATH"?

If you have:

PATH=c:\bin;c:\python\bin

The set would become:

set PATH=c:\bcc\bin;"c:\bin;c:\python\bin"

Which would result in having quotes inside the PATH var which is wrong AFAIK.

>>Is the intent more like this:
>>
>>	set "PATH=$(BCC_TOOL_PATH);%PATH%"

> How do I know? I don't understand WinQuoting ;-)

Not sure anyone does ;-]

>>Which for me on WinXP keeps all the spaces and other char intact.
> 
> 
> Sounds about right; want to check in a fix?

Sure.

-- 
-- Grafik - Don't Assume Anything
-- Redshift Software, Inc. - http://redshift-software.com
-- rrivera_at_[hidden] - grafik_at_[hidden] - 102708583_at_icq