Re: [jamboost] Re: msvc-stlport-tools patch

From: John Maddock (john_at_[hidden])
Date: 2003-12-23 06:18:51

> > -flags msvc-stlport STLPORT_VERSION <stlport-version> ;
> > +flags msvc-stlport STLPORT_VERSION_FLAG <stlport-version> : ;
>
> Sorry it took me so long to look at this. The change above looks
> really suspicious to me. STLPORT_VERSION_FLAG isn't used anywhere
> else in the toolset AFAICT.

The thing is the original version trampled all over STLPORT_VERSION each
time the toolset was invoked, resetting it to the default value each time.
I'll be honest I don't actually understand why that line is in there -
except that without it <stlport-version> gets ignored; as long as the macro
name is something that's unused though it all works. If you have a better
patch that's fine by me, but please make sure that STLPORT_VERSION is
actually honored - as it is at present.

Thanks,

John.