Re: [jamboost] Re: msvc-stlport-tools patch

From: John Maddock (john_at_[hidden])
Date: 2003-12-24 07:07:26

> On second look your patch seems mostly fine. I'd suggest two changes:
>
> local version ;
> version ?= [ get-values <stlport-version> : $(gBUILD_PROPERTIES) ] ;
> version ?= $(STLPORT_VERSION) ;
>
> The first use of ?= doesn't make any sense; version is always empty
> after you declare it local, so you might as well write:
>
> local version = [ get-values <stlport-version> :
$(gBUILD_PROPERTIES) ] ;
> version ?= $(STLPORT_VERSION) ;
>
> The other is to change STLPORT_VERSION_FLAG to something like
> unused-flag-just-to-make-<stlport-version>-relevant .

Done (called it THIS_FLAG_IS_UNUSED_BUT_ENSURES_TAG_ISNT_IGNORED), thanks.

John.