Re: [jamboost] patch (Was: v2 on Mac OS X)

From: Vladimir Prus (ghost_at_[hidden])
Date: 2004-02-20 03:59:38

Hi Andre,

> Vladimir Prus wrote:
> > Of course, it's not that bad. One can start by inlining toolset.inherit
> > call:
>
> Thanks for you help. I've implemented that idea following your
> instructions. I also make changes in several places to make most tests
> pass (3 are still failing). The patch is attached.

I've comitted your patch. Thanks a lot!

> I was wondering if
> $(.$(rule-or-module).condition.$(f))
> is the right thing to use as a filter since it contains the condition as
> in <debug-symbols>off (and <debug-symbols>on). I suppose this is what we
> want but thought I would bring that issue to your attention.

I think we can use either filtering on property and filtering on feature. I 
see no good arguments in favour of either one, it's only important that 
comment state which one is used. Thanks for noticing/documenting that.

I have one concern about your patch though. In 'prebuilt' test there was 
"import gcc ; " which you replaced with "import $toolset; ". I wonder if the 
import belongs there at all -- generally we assume that either 
user-config.jam for test-config.jam will declare all toolsets which are used 
for testing. So, maybe the import should be removed?

- Volodya