Re: Resource files support (v2)

From: Andre Hentz (ahentz_at_[hidden])
Date: 2004-06-01 12:16:17

Hi Alexey,

your patch looks good. Apart from what Volodya said, I want to point 
out two things that don't affect me directly but might break other 
peoples code.

First, rc.jam has:

# Since it's a common practice to write
# exe hello : hello.cpp hello.rc
# we change the name of object created from RC file, to
# avoid conflict with hello.cpp.
generators.register-standard rc.resource-compile : RC : OBJ(%_res) ;

which was a requirement from someone. It should be trivial to include 
that along with your modifications.

Second, I believe that if you are running toolset=msvc under cygwin, 
you still want to run rc.exe, not windres.exe. If you are running 
toolset=gcc, then you would have to run windres.exe. Along those lines, 
if your modifications don't provide for toolset=gcc, we need to make 
sure no one needs that (I do compile with gcc/cygwin but don't need to 
run RC in that case).

Other than that, your changes are most welcome.

Best,

Andre Hentz

Alexey Pakhunov wrote:
> Hi Vladimir,
> 
> 
>>I have some concerns about it. For example, I thing resource compiler can be
>>used just fine with borland, and your change makes this harder. For now, I
>>don't know what's the right approach is. If rc.jam is separate, then it's
>>hard to generically grab the location of vcvars32.bat.
>>
>>Maybe, we can keep separate rc.jam for the sake of borland, and add generators
>>for rc files to msvc.jam as well. The latter will be used only when toolset
>>is "msvc".
> 
> 
> Well, one solution that I see: wrote own rules for building rc for each
> compiler. Another one - use a global variable containing prefix and name of
> resource compiler.
> 
> 
>>Again, I don't think anybody is working on this, and this surely seems good
>>addition! Maybe, you can send a patch?
> 
> 
> See the attachment.
> 
> 
>>As for message compiler, I'd appreciate if we have some discussion before you
>>implement this feature. V2 already has support for GNU gettext tool, and it
>>would be nice if MC support has similiar interface.
> 
> 
> I need to investigate what is gettext, how it is used, etc. So it will take some
> time. :-)
>