Re: [jamboost] Re: Resource files support (v2)

From: Vladimir Prus (ghost_at_[hidden])
Date: 2004-06-04 04:01:36

Alexey Pakhunov wrote:

> Withouth them bjam won't be able to link resources to resulting
> dll/exe/lib. The attached file is corrected version of the patch.

Hi Alexey,

I have some comments on your patch:

1. The transform and replace methods really don't belong to "res-scanner". It 
would be much more reasonable to add them to the regex module. As for 
replace, I think it is possible to extend regex.replace to accept list, not 
string as the first argument.
2. Why do you need to replace all double backslashes with signle ones? I'm 
sure you have a reason, I'd just like it to be present as comment
3. The 'process' rule ends with:

scanner.propagate c-scanner : $(angle) $(quoted) : $(target) ;

Actually, I don't know much about RC files, so don't know if this correct: do 
you really need c-scanner. I realize we can include header which can include 
another header. I wonder if RC files can include other *RC* files?

Other than this issues, I think you patch can be comitted. Would you be 
willing to send a corrected version?

- Volodya