Re: [jamboost] Patch : Removal of temporary .bat files on NT/XP/2000

From: Vladimir Prus (ghost_at_[hidden])
Date: 2004-07-19 10:38:19

Hi Dean,

> I'm just starting to look at using boost.Jam as a replacement for our
> current makefile & VS.NET project defined build processes. While
> testing, I noticed that jam leaves .bat files within $(TEMP)..
>
> It would appear that this was fixed in Perforce's distribution (Jam
> 2.5rc2 and rc3 have the fix) in execunix.c (which is used even for NT
> builds), but I figured I might as well apply the fix to execnt.c
> (which is used by boost.Jam when running on NT). It seems to work
> perfectly.
>
> Here's the diff against 'execnt.c' from boost.Jam 3.1.9 (compiled from
> the source in boost_1_31_0.tar.gz)
>
> 743a744,747
>
> > /* Remove our temporary .bat file */
> > if ( cmdtab[ i ].tempfile )
> > unlink( cmdtab[ i ].tempfile );

I've applied this change, could you grab the CVS version of bjam and see if it 
works OK.

For the future patches, I'd be gratefull if you:
1. Send unified diff (produced with "cvs -u" or "diff -u"), to make sure 
automatic application always work
2. Send the file as attachment, to save the trouble of copy-pasting
3. Don't strip the patch header
4. Make the patch against CVS version

It might sound like nit-picking but really, it's not very convenient to apply 
patches otherwise:

$ patch < A.diff
can't find file to patch at input line 1
Perhaps you should have used the -p or --strip option?
File to patch:
$ patch execnt.c A.diff
patching file execnt.c
patch unexpectedly ends in middle of line
patch: **** unexpected end of file in patch at line 4

And the only thing I could do is go looking at perforce version.

Thanks,
Volodya