Re: [jamboost] Possible regressions?

From: Vladimir Prus (ghost_at_[hidden])
Date: 2004-09-29 05:02:01

Zbynek Winkler wrote:

> This is really strange. I just updated to the latest cvs version and I
> still have this problem. Actually runing with -d2 gives me:
>
> echo FOX-1.2 >> "bin\msvc-7.1\debug\threading-multi\main.rsp"
>
> I experimented with it and the reason is that there is a dot in the
> name. When I remove it, the lib suffix is appended. So I guess this
> would be a bug?

Yes, *that* is a bug indeed. I've just committed the attached patch which 
should take care of it.

> Sorry, my example was not complete. The following exibits the error with
> latest cvs when calling bjam with no params. When building only target
> a, it works.
>
> project
>
> : requirements <threading>multi
>
> ;
>
> lib test : : <name>test <toolset>gcc ;
> lib test : : <name>test.lib <toolset>msvc ;
> exe a : a.cpp test ;

Oh, this is more or less known problem, though it was off my radar for some 
time. I've filed an issue about this, so that I don't forget:

http://zigzag.cs.msu.su:7814/scarab/issues/id/BB78

- Volodya
 --Boundary-00=_ZgoWBKZeshjoy3p Content-Type: text/x-diff;
charset="utf-8";
name="utility.jam.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="utility.jam.diff"

Index: utility.jam
===================================================================
RCS file: /cvsroot/boost/boost/tools/build/v2/util/utility.jam,v
retrieving revision 1.11
diff -u -r1.11 utility.jam
--- utility.jam	5 Aug 2003 05:25:32 -0000	1.11
+++ utility.jam	29 Sep 2004 09:49:23 -0000
@@ -76,20 +76,20 @@
}
}

-# For all elements of 'list' which do not have a suffix,
+# For all elements of 'list' which do not already have 'suffix',
# add 'suffix'.
rule apply-default-suffix ( suffix : list * )
{
local result ;
for local i in $(list)
{
- if $(i:S)
+ if $(i:S) = $(suffix)
{
result += $(i) ;
}
else
{
- result += $(i:S=$(suffix)) ;
+ result += $(i)$(suffix) ;
} 
}
return $(result) ; 
@@ -134,7 +134,7 @@
assert.false equal 1 2 ;
assert.result "not sure" : equal [ new test-class__ ] 1 ;

- assert.result foo.lib foo.a : apply-default-suffix .lib : foo foo.a ;
+ assert.result foo.lib foo.lib : apply-default-suffix .lib : foo.lib foo.lib ;
}

 --Boundary-00=_ZgoWBKZeshjoy3p--