Re: [jamboost] Boost jam patch to improve locating source directories

From: Vladimir Prus (ghost_at_[hidden])
Date: 2005-05-24 03:59:37

On Tuesday 24 May 2005 00:02, Craig Rodrigues wrote:
> On Mon, May 23, 2005 at 11:18:24AM +0400, Vladimir Prus wrote:
> > Unfortunately, I get failures for the 'absolute_sources' and 'standalone'
> > tests. Could you look into those? You can run the test with
> >
> > python absolute_source.py
> >
> > and with
> >
> > python absolute_source.py --preserve
> >
> > the failing Boost.Build project will be copied to "failed_test" dir.
>
> Can you add those two tests to test_all.py?

They are there already.

> I think those tests were failing, because
> in targets.jam, the location() function
> was returning the empty string for
> files that existed, but were specified with an absolute path,
> and the project source-location was not being set.
>
> This caused the exists() function to return
> false, even for files which existed.
>
> I ran the regression tests with this patch,
> can you try it?

Everything passed!

I've committed the patch. Thanks!

The testcase, however small, would still be nice ;-)

> P.S. What coding conventions are followed in Boost Jam?
> If I edit the files with vim, I notice that
> there are many files with trailing whitespace.

They are documented in $v2_root/hacking.txt
Any trailing whitespace should be considered bogus.

- Volodya