Re: bad dependency generation

From: David Abrahams (dave_at_[hidden])
Date: 2005-05-25 10:05:38

Vladimir Prus <ghost_at_[hidden]> writes:

> On Wednesday 25 May 2005 18:20, David Abrahams wrote:
>> Vladimir Prus <ghost_at_[hidden]> writes:
>> > - DEPENDS $(rsp) : $(sources) ;
>>
>> What makes it OK to delete this line?
>
> Your own comment! Mentioned in the patch itself:
>
> + # Note: we don't need dependecy from response file on sources
> + # because response file only needs the names of the sources.

Uhm, wait. I did say the response file only needs the names of the
sources. I did *NOT* draw the conclusion that we don't need a
dependency on the sources.

> That's true, response file will be created before the target, and it only
> need the name of sources, not their content, and so should not depend on them.

That can never work. If the .rsp doesn't exist to begin with, then
the target will never built, because it depends on the .rsp and there
are no instructions for building the .rsp.

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com