Re: [jamboost] Re: [v2] Overuse of response files?

From: Vladimir Prus (ghost_at_[hidden])
Date: 2005-06-03 07:58:42

On Friday 03 June 2005 16:01, David Abrahams wrote:
> Vladimir Prus <ghost_at_[hidden]> writes:
> > On Thursday 02 June 2005 23:41, David Abrahams wrote:
> >> > Oh; I dug around but couldn't find it.
> >>
> >> Okay, I applied the patch you referenced, and still nothing works:
> >>
> >> ...found 99 targets...
> >> ...updating 9 targets...
> >> warning: using independent target
> >> <pbin\is_fixed_size.test\msvc-8.0\debug>is_fixed_size_cpp.rsp
> >> msvc.compile.c++ bin\is_fixed_size.test\msvc-8.0\debug\is_fixed_size.obj
> >> bin\is_fixed_size.test\msvc-8.0\debug\is_fixed_size_cpp.rsp cl : Command
> >> line error D8022 : cannot open
> >> 'bin\is_fixed_size.test\msvc-8.0\debug\is_fixed_size_cpp.rsp'
> >>
> >>
> >> <snip>
> >>
> >> I think I might've mis-applied it. I have something that's working
> >> for me now; I'm going to check it in.
> >
> > Okay, please go ahead. I'll check check if it works on my end after that.
>
> Done. Incidentally, it appears MSVC is the only one using RSPs for
> C++ -> OBJ compilation. We should find a way to factor out more
> commonality in actions here so it's easier to apply to como et al.

And guess what. I've got the same error as you. I've committed the attach that 
seem to finally fix this. Have no idea what's going on -- some strange bjam
behaviour with TEMPORARY targets.

So now, response files are deleted if everything's OK, and left in place 
otherwise. Anything else we should do?

- Volodya

-- 
Vladimir Prus
http://vladimir_prus.blogspot.com
Boost.Build V2: http://boost.org/boost-build2
 --Boundary-00=_DQFoCTjDDercXED Content-Type: text/x-diff;
charset="iso-8859-1";
name="common.jam.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="common.jam.diff"
Index: common.jam
===================================================================
RCS file: /cvsroot/boost/boost/tools/build/v2/tools/common.jam,v
retrieving revision 1.37
diff -u -r1.37 common.jam
--- common.jam	3 Jun 2005 12:00:35 -0000	1.37
+++ common.jam	3 Jun 2005 12:54:38 -0000
@@ -429,15 +429,17 @@
# TODO: now 'the-response-file' is just ignored. Need to remove
# the argument altother and adjust callers.
- # Create a target for response file. Not that we add 'rsp' to the target
+ # Create a target for response file. Note that we add 'rsp' to the target
# name (without stripping suffix), so that response file names for c.exe
# and c.obj are different.
local rsp = $(targets[1]).rsp ;
RSP on $(targets) = $(rsp) ;
LOCATE on $(rsp) = [ on $(targets[1]) return $(LOCATE) ] ;
DEPENDS $(targets) : $(rsp) ;
- # Note: we don't need dependecy from response file on sources
+ # In theory, we don't need dependecy from response file on sources
# because response file only needs the names of the sources.
+ # In practice, bjam won't recreated TEMPORARY target without dependencies.
+ DEPENDS $(rsp) : $(sources) ;
TEMPORARY $(rsp) ;
# Add libraries from <library> property to the list of sources.
 --Boundary-00=_DQFoCTjDDercXED--