Re: [v2] msvc.jam

From: David Abrahams (dave_at_[hidden])
Date: 2005-06-08 11:37:25

Vladimir Prus <ghost_at_[hidden]> writes:

> Hi Olaf,
>
>> actions compile.c bind RSP
>> {
>> $(.CC) /Zm800 -nologo -TC -U$(UNDEFS) $(CFLAGS) $(USER_CFLAGS)
>> @"$(RSP:W)" -c -Fo"$(<[1]:W)" && del "$(RSP)"
>> }
>> actions compile.c++ bind RSP
>> {
>> $(.CC) /Zm800 -nologo -TP -U$(UNDEFS) $(CFLAGS) $(USER_CFLAGS)
>> @"$(RSP:W)" -c -Fo"$(<[1]:W)"
>> }
>>
>> It seems that '&& del "$(RSP)"' has been forgotten in the c++ action.
>
> You are right.
>
>> Second: version 1.39 changed the check
>>
>> if [ MATCH ^(8) : $(version) ]
>>
>> to
>>
>> if ! [ MATCH ^([67]\..*) : $(version) ]
>>
>> This breaks our build system which uses the toolset name 'msvc-6'. I
>> changed it to
>>
>> if ! [ MATCH ^([67]\.?.*) : $(version) ]
>>
>> but maybe another regular expression is more appropriate.
>
> I think that ^([67]\.?.*) is the same as ^([67].*).
>
> I've made both changes and committed. Thanks!

I know it's a little pedantic, but I think 

^([67](\.[0-9]*))?

would be more appropriate. Eventually there may be a version 60.0 ;-)

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com