Re: [jamboost][BBv2][msvc] amd64, ia64, psdk - patch status

From: Andrey Melnikov (melnikov_at_[hidden])
Date: 2005-08-29 17:21:57

Alexey Pakhunov wrote:

> Coding is done. I'm planning to finish testing on Cygwin in a couple 
> of days. Then I'll post it here.
> 
> BTW the patch itself consists of five parts:
> 
> 1. msvc changes
> 2. MS Platform SDK stuff
> 3. midl support (midl.jam)
> 4. message compiler support (mc.jam)
> 5. A small fix of rc.jam
> 
> Only the first two will require a careful review. midl.jam was discussed a 
> lot and there were no additional comments since I posted it as a part of 
> "amd64, ia64, etc." patch (The patch I started this thread with). 4 and 
> 5 were also parts of this patch and there were no comments about them.
> 
> So it looks like the review is done for 3-5. If it is not so, please 
> write your comments. 
> (http://article.gmane.org/gmane.comp.lib.boost.build/9814)

According to Vladimir Prus, "the problem was that the patch was very 
large". It's hard to comment on so many things at the same time. You'll 
have to split the patch into the five parts and submit them 
independently. The review isn't complete because the patch was too large.

I'd suggest to publish the patch as it is now. It's likely that there 
will be some conceptual/architectural flaws. It isn't a good idea to 
test the details if the large picture is still unstable. You are 
probably wasting time testing now, because you'll have to test it again 
after the review. We (at least me) aren't going to punish you because 
the patch you are submitting isn't mature. Frequent peer reviews is a 
good idea.

Andrey