Re: [jamboost][BBv2][msvc] multiple patches by Aleksey Pakhunov

From: Rene Rivera (grafik.list_at_[hidden])
Date: 2005-08-30 22:58:24

Andrey Melnikov wrote:
> I tried to decompose your megapatch. Here are the subpatches I see:

I was just starting to look at the patches also...

> - the new msplatformsdk feature (without corresponding support in the 
> toolsets)

At minimum needs a better name if this is going to be a global feature.

> - new cpu-arch feature (without support)

A single "cpu-arch" is not sufficient here. If you look at the BBv1 
equivalent there are three features: address-model, architecture, and 
instruction-set, to handle the possibilities for controlling code 
generation. And there's are way more possibilities than i386, amd64 and 
ia64 ;-) ...I've gone ahead and transplanted, and added, the features 
present in BBv1 for this into BBv2.

[cut]

> There are 14 distinct almost independent changes, and each of the 
> changes should be grounded enough in order to be accepted. I think we 
> should discuss and submit to CVS each change separately.

Yes. It's 13 now :-) Some of those items will take some consideration as 
they require some thinking about how to generalize the ideas to other 
toolsets.

-- 
-- Grafik - Don't Assume Anything
-- Redshift Software, Inc. - http://redshift-software.com
-- rrivera/acm.org - grafik/redshift-software.com
-- 102708583/icq - grafikrobot/aim - Grafik/jabber.org