Re: [BBv2] alignment feature and msvc assembler support

From: Alexey Pakhunov (alexeypa_at_[hidden])
Date: 2005-09-18 11:32:46

Reece Dunn wrote:
> I read the definitions of the feature types to see which was appropriate 
> :). I have made it propagated as well.

:-)

> +local i386 =
> + <architecture>/<address-model>
> + <architecture>/<address-model>32
> + <architecture>x86/<address-model>
> + <architecture>x86/<address-model>32
> + ;
> +
> +local ia64 =
> + <architecture>/<address-model>64
> + <architecture>ia64/<address-model>
> + <architecture>ia64/<address-model>64
> + ;
> +
> +local amd64 =
> + <architecture>/<instruction-set>athalon64/<address-model>
> + <architecture>/<instruction-set>athalon64/<address-model>64
> + <architecture>ia64/<instruction-set>athalon64/<address-model>
> + <architecture>ia64/<instruction-set>athalon64/<address-model>64
> + ;

I think it should be:

local ia64 =
<architecture>ia64/<address-model>
<architecture>ia64/<address-model>64
;

local amd64 =
<architecture>/<address-model>64
<architecture>x86/<address-model>64
;

> +# Declare flags and action for the assembler
> +
> +flags msvc.asm ASMFLAGS $(i386)/<asynch-exceptions>on/<safe-asynch-exceptions>on : /safeseh ;
> +flags msvc.asm ASMFLAGS <alignment>1 : /Zp1 ;

What about this:

flags msvc.asm ASMFLAGS 
$(i386)/<asynch-exceptions>on/<safe-asynch-exceptions>off : /safeseh:no ;

The rest looks good.

Best regards/Venlig hilsen,
Alexey Pakhunov.