Re: [jamboost] Re: Review: Optional features in toolset.flags

From: Vladimir Prus (ghost_at_[hidden])
Date: 2005-09-19 04:05:23

Hi Alexey,

> Vladimir Prus wrote:
> > The trick used in msvc.jam for that is to define a global variable. Say:
> >
> > .SETUP = "x86" ;
> > flags msvc .SETUP <architecture>x86/<address-model>32 : " x86" ;
> > flags msvc .SETUP <architecture>x86/<address-model>64 : " x86_amd64" ;
> > flags msvc .SETUP <architecture>ia64/<address-model>64 : " x86_ia64" ;
> >
> > Now, if neithe condition matches, you get the global value. Will that be
> > enough?
>
> No, because I want to match such conditions as
>
> flags msvc .SETUP <architecture>/<address-model>64 : " x86_amd64" ;
> flags msvc .SETUP <architecture>ia64/<address-model> : " x86_ia64" ;

Point taken.

> > This comment is hard to understand, due to double use of "such" and
> > unclear meaning of "used for matching". Can you try to improve?
>
> Sure.
>
> > Also, I suggest that you change the description of the 'flags' rule to
> > mention this use case.
>
> Added.

Thanks. I see you've modified the logic a bit, and this makes the change much 
easier to understand.

I've committed the patch. Thanks for your patience!

- Volodya

-- 
Vladimir Prus
http://vladimir_prus.blogspot.com
Boost.Build V2: http://boost.org/boost-build2