Re: [BBv2] Patch, review needed - support of Microsoft .idl files for MSVC

From: Reece Dunn (msclrhd_at_[hidden])
Date: 2005-10-13 17:22:42

"Alexey Pakhunov" <alexeypa_at_[hidden]> wrote:
> Hi All.
>
> This is almost the same patch as I posted a while ago with several
> enhancements. What was changed:
>
> - The target type 'TLB' was renamed to 'MSTYPELIB' and it is derived
> from 'H' now. This also affects the main target rule 'tlb'. It became
> 'mstypelib';
> - Regular expressions in midl-scanner were made more readable;
> - <architecture> and <address-model> features are used;

Cool. I won't have access to my development machine until the weekend, so
won't be able to comment on the changes until then, so for now I will
comment on the initial patch.

> The rest remains the same. The patch has been used for a while by Reece
> Dunn (thanks Reece :) ) and appears to be working.

Thanks. I have been using this patch in several projects and have found
that:

[1] If you have a projects and a projects/mycomobj directory, where projects
has:
build-project mycomobj ;
and mycomobj has an IDL target that contains
mycomobj/core/core.idl
and
mycomobj/advanced/advanced.idl
where advanced.idl imports core.idl, it will work if you build from
mycomobj, everything builds fine, but if you build from projects, it cannot
locate core.idl.

All I know is that the include path is somehow getting mixed up. I haven't
checked with the latest version but will check to see if this is still an
issue.

[2] It appears that the IDL files are being rebuilt each time which is
causing everything else to be rebuilt by BBv2 as it is picking up the IDL
header files as being out of date.

I will recheck these issues, but I don't see them as being showstoppers and
vote in favour of the patch. Nice work.

- Reece