Re: [Boost-build] [BBv2] PCH problems

From: Reece Dunn (msclrhd_at_[hidden])
Date: 2005-12-07 04:29:58

Vladimir Prus wrote:
>On Monday 05 December 2005 20:09, Reece Dunn wrote:
> > Feel free to make the necessary changes and then submit. Thanks again 
>for
> > the help :).
>
>The patch is now committed.

Great.

>1. I also remove <pch-file> features in addition to <pch-header>. Is that
>right?

Yes.

>2. Can you test your examples -- I don't have msvc handy.

I have run my tests and they work fine.

>Speaking about 'cast' -- I think we can get away with it. The pch generator
>only makes sense as top-level target -- i.e. when building "pch" main 
>target.
>It does not make sense to automatically try conversion to "PCH" type when
>building some other main targets.
>
>So, just wrap the body of "pch-generator.run" in
>
>   if $(name)
>   {
>   }
>
>This will make sure the generator is only run inside "pch" main target.
>I can commit the change any time, but I have no idea how to test for the
>problem.

I tried this, along with the removal of [ cast ... ] to the PCH stuff. I 
also needed to add a generator for H and one for HPP to allow stdafx.h or 
pch.hpp as your header. This worked fine except for MC which gave an 
ambiguity error:

   MC -> RC -> OBJ
     \-> H -> PCH -> OBJ

which I don't know how to solve :( (hence the cast).

- Reece