Re: [Boost-build] CVS: boost/tools/build/v2/build project.jam, 1.114, 1.115

From: Rene Rivera (grafik.list_at_[hidden])
Date: 2006-04-07 12:00:14

Vladimir Prus wrote:
> On Thursday 23 February 2006 20:52, Rene Rivera wrote:
> 
>> -JAMROOT = project-root.jam [Jj]amroot [Jj]amroot.jam ;
>> +JAMROOT ?= [ peek : JAMROOT ] ;
>> +JAMROOT ?= project-root.jam [Jj]amroot [Jj]amroot.jam ;
>> +
>>  # Loads parent of Jamfile at 'location'. Issues an error if nothing is
>> found. rule load-parent ( location )
>>  {
>> @@ -106,8 +108,8 @@
>>
>>      if ! $(found)
>>      {
>> -        ECHO "error: Could not find parent for project at '$(location)'" ;
>> -        ECHO "error: Did not find Jamfile or project-root.jam in any
>> parent directory." ; +        error "Could not find parent for project at
>> '$(location)'" +            : "Did not find Jamfile or project-root.jam in
>> any parent directory." ; EXIT ;
> 
> This change cause stacktrace to be shown when Jamroot can't be found. Is this 
> a desired behaviour?
> 
> Users seems to be confused by long stacktrace, and in this case, it's not an 
> internal error where stack trace makes sense.
> 
> What do you think? 

I agree... But we should have an equivalent to the "error" rule that 
does it. It's was the raw ECHO+EXIT I wanted to remove, since the output 
formatting wasn't consistent with the rest of the program error messages.

-- 
-- Grafik - Don't Assume Anything
-- Redshift Software, Inc. - http://redshift-software.com
-- rrivera/acm.org - grafik/redshift-software.com
-- 102708583/icq - grafikrobot/aim - grafikrobot/yahoo