Re: [Boost-build] [v2] globbing subdirectories with same file name

From: Vladimir Prus (ghost_at_[hidden])
Date: 2006-05-24 02:00:10

On Wednesday 24 May 2006 05:20, Ryan Gallagher wrote:
> Vladimir Prus <ghost <at> cs.msu.su> writes:
> [snip]
>
> > Hi Ryan,
> > I've committed a revised version of your patch, together with test. The
> > important thing is that we check for ".." in source path, and if it's
> > there, strip the directory completely.
> >
> > Can you get nightly build and check if things work as you like?
>
> Thanks Volodya,
>
> I'll try this out tomorrow and get back to you.  Good catch on the ".."'s;
> FWIW I think your solution sounds reasonable.
>
> For educational purposes I'm a bit interested in what was revised other
> than the ".." case.  If you get a chance would you let me know?  (Sorry, I
> don't have direct cvs access to do a cvs diff on it.)

Basically, instead of replaing *first* call to 'utility.basename' with call to 
a a new rule, I've added handling for relative paths after basename of the 
generated targets is computed. You see, there were two calls to 
utility.basename, and you've changed just one. I'm not sure if this will hit 
us anywhere, but better handle path just once.

Also, I've made the 'glob' rule (in project context), compute relative paths 
if possible.

- Volodya

-- 
Vladimir Prus
http://vladimir_prus.blogspot.com
Boost.Build V2: http://boost.org/boost-build2