Re: [Boost-build] pch-support for gcc, msvc and dmc

From: Andrei Melnikov (andy.melnikov_at_[hidden])
Date: 2006-06-09 18:23:51

It's hard to review such large patches. I think it's better to
separate it into several smaller patches. I think you should at least
extract "minor non-functional code cleanups" into a separate patch. I
think such cleanups are definitely improvements, and the subpatch
should be applied immediately before the discussion of proposed
<toolset>-cpp-pch framework can start.

By "non-functional cleanups" I mean changes such as:

-flags msvc.link LINKFLAGS <debug-symbols>on : /DEBUG ;
+flags msvc.link OPTIONS <debug-symbols>on : /DEBUG ;

...

-flags msvc.compile.c OPTIONS <cflags> : ;
-flags msvc.compile.c++ OPTIONS <cxxflags> : ;
+flags msvc.compile.c CFLAGS <cflags> : ;
+flags msvc.compile.c++ C++FLAGS <cxxflags> :

and so on. Also, it seems you forgot to remove commented lines:

+
+#type.set-generated-target-suffix MSVC_CPP_PCH_T : <toolset>msvc : pch ;
+#type.set-generated-target-suffix MSVC_C_PCH_T   : <toolset>msvc : pch ;
+

Regards,
Andrei

P.S. Due to some reason, the attachments have Content-disposition:
inline, and gmail web interface (correctly) refuses to recognize them
as attachments, so I couldn't save them.